Skip to content

Commit e14fd2a

Browse files
peda-rvinodkoul
authored andcommitted
dmaengine: at_hdmac: Extend the Flow Controller bitfield to three bits
Some chips have two bits (e.g SAMA5D3), and some have three (e.g. SAM9G45). A field width of three is compatible as long as valid values are used for the different chips. There is no current use of any value needing three bits, so the fixed bug is relatively benign. Fixes: d8840a7 ("dmaengine: at_hdmac: Use bitfield access macros") Cc: [email protected] Reviewed-by: Tudor Ambarus <[email protected]> Signed-off-by: Peter Rosin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 2a6c7e8 commit e14fd2a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/dma/at_hdmac.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@
132132
#define ATC_DST_PIP BIT(12) /* Destination Picture-in-Picture enabled */
133133
#define ATC_SRC_DSCR_DIS BIT(16) /* Src Descriptor fetch disable */
134134
#define ATC_DST_DSCR_DIS BIT(20) /* Dst Descriptor fetch disable */
135-
#define ATC_FC GENMASK(22, 21) /* Choose Flow Controller */
135+
#define ATC_FC GENMASK(23, 21) /* Choose Flow Controller */
136136
#define ATC_FC_MEM2MEM 0x0 /* Mem-to-Mem (DMA) */
137137
#define ATC_FC_MEM2PER 0x1 /* Mem-to-Periph (DMA) */
138138
#define ATC_FC_PER2MEM 0x2 /* Periph-to-Mem (DMA) */

0 commit comments

Comments
 (0)