Skip to content

Commit e1533b6

Browse files
abajkkuba-moo
authored andcommitted
net: ethernet: lantiq_etop: fix double free in detach
The number of the currently released descriptor is never incremented which results in the same skb being released multiple times. Fixes: 504d472 ("MIPS: Lantiq: Add ethernet driver") Reported-by: Joe Perches <[email protected]> Closes: https://lore.kernel.org/all/[email protected]/ Signed-off-by: Aleksander Jan Bajkowski <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 01fc514 commit e1533b6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/ethernet/lantiq_etop.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,9 +217,9 @@ ltq_etop_free_channel(struct net_device *dev, struct ltq_etop_chan *ch)
217217
if (ch->dma.irq)
218218
free_irq(ch->dma.irq, priv);
219219
if (IS_RX(ch->idx)) {
220-
int desc;
220+
struct ltq_dma_channel *dma = &ch->dma;
221221

222-
for (desc = 0; desc < LTQ_DESC_NUM; desc++)
222+
for (dma->desc = 0; dma->desc < LTQ_DESC_NUM; dma->desc++)
223223
dev_kfree_skb_any(ch->skb[ch->dma.desc]);
224224
}
225225
}

0 commit comments

Comments
 (0)