Skip to content

Commit e17c120

Browse files
committed
Merge tag 'array-bounds-fixes-5.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux
Pull array-bounds fixes from Gustavo Silva: "Fix an out-of-bounds warning in the media subsystem. This is part of the ongoing efforts to globally enable -Warray-bounds" * tag 'array-bounds-fixes-5.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux: media: siano: Fix out-of-bounds warnings in smscore_load_firmware_family2()
2 parents 8ec035a + 13dfead commit e17c120

File tree

2 files changed

+11
-15
lines changed

2 files changed

+11
-15
lines changed

drivers/media/common/siano/smscoreapi.c

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,7 @@ static int smscore_load_firmware_family2(struct smscore_device_t *coredev,
908908
void *buffer, size_t size)
909909
{
910910
struct sms_firmware *firmware = (struct sms_firmware *) buffer;
911-
struct sms_msg_data4 *msg;
911+
struct sms_msg_data5 *msg;
912912
u32 mem_address, calc_checksum = 0;
913913
u32 i, *ptr;
914914
u8 *payload = firmware->payload;
@@ -989,24 +989,20 @@ static int smscore_load_firmware_family2(struct smscore_device_t *coredev,
989989
goto exit_fw_download;
990990

991991
if (coredev->mode == DEVICE_MODE_NONE) {
992-
struct sms_msg_data *trigger_msg =
993-
(struct sms_msg_data *) msg;
994-
995992
pr_debug("sending MSG_SMS_SWDOWNLOAD_TRIGGER_REQ\n");
996993
SMS_INIT_MSG(&msg->x_msg_header,
997994
MSG_SMS_SWDOWNLOAD_TRIGGER_REQ,
998-
sizeof(struct sms_msg_hdr) +
999-
sizeof(u32) * 5);
995+
sizeof(*msg));
1000996

1001-
trigger_msg->msg_data[0] = firmware->start_address;
997+
msg->msg_data[0] = firmware->start_address;
1002998
/* Entry point */
1003-
trigger_msg->msg_data[1] = 6; /* Priority */
1004-
trigger_msg->msg_data[2] = 0x200; /* Stack size */
1005-
trigger_msg->msg_data[3] = 0; /* Parameter */
1006-
trigger_msg->msg_data[4] = 4; /* Task ID */
999+
msg->msg_data[1] = 6; /* Priority */
1000+
msg->msg_data[2] = 0x200; /* Stack size */
1001+
msg->msg_data[3] = 0; /* Parameter */
1002+
msg->msg_data[4] = 4; /* Task ID */
10071003

1008-
rc = smscore_sendrequest_and_wait(coredev, trigger_msg,
1009-
trigger_msg->x_msg_header.msg_length,
1004+
rc = smscore_sendrequest_and_wait(coredev, msg,
1005+
msg->x_msg_header.msg_length,
10101006
&coredev->trigger_done);
10111007
} else {
10121008
SMS_INIT_MSG(&msg->x_msg_header, MSG_SW_RELOAD_EXEC_REQ,

drivers/media/common/siano/smscoreapi.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -624,9 +624,9 @@ struct sms_msg_data2 {
624624
u32 msg_data[2];
625625
};
626626

627-
struct sms_msg_data4 {
627+
struct sms_msg_data5 {
628628
struct sms_msg_hdr x_msg_header;
629-
u32 msg_data[4];
629+
u32 msg_data[5];
630630
};
631631

632632
struct sms_data_download {

0 commit comments

Comments
 (0)