Skip to content

Commit e1b3123

Browse files
dbalutamathieupoirier
authored andcommitted
dt-bindings: dsp: fsl,dsp: Add resets property
Assert and deassert functionality of the DSP found on i.MX8MP is realized by combining control bits from two modules: Audio Block Control and Debug Access Port. Audio block control bits are used to Run/Stall the DSP core while the DAP bits are used for software reset the core. The original plan was to use fsl,dsp-ctrl property and to refer the audiomix bits via syscon interface. This proposal received NACK from community we shouldn't abuse the syscon interface [1]. So remove fsl,dsp-ctrl property for i.MX8MP and use reset control interface instead. Example dts node only uses runstall control now, but softreset will be added in the future when we will convert the softreset functionality to use reset controller API. [1] https://patchwork.kernel.org/project/imx/patch/[email protected]/ Reviewed-by: Rob Herring (Arm) <[email protected]> Reviewed-by: Frank Li <[email protected]> Signed-off-by: Daniel Baluta <[email protected]> Acked-by: Philipp Zabel <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mathieu Poirier <[email protected]>
1 parent cd9cceb commit e1b3123

File tree

1 file changed

+23
-1
lines changed

1 file changed

+23
-1
lines changed

Documentation/devicetree/bindings/dsp/fsl,dsp.yaml

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,15 @@ properties:
8282
description:
8383
Phandle to syscon block which provide access for processor enablement
8484

85+
resets:
86+
minItems: 1
87+
88+
reset-names:
89+
minItems: 1
90+
items:
91+
- const: runstall
92+
- const: softreset
93+
8594
required:
8695
- compatible
8796
- reg
@@ -164,6 +173,17 @@ allOf:
164173
- const: txdb1
165174
- const: rxdb0
166175
- const: rxdb1
176+
- if:
177+
properties:
178+
compatible:
179+
contains:
180+
enum:
181+
- fsl,imx8mp-dsp
182+
- fsl,imx8mp-hifi4
183+
then:
184+
required:
185+
- resets
186+
- reset-names
167187

168188
additionalProperties: false
169189

@@ -186,6 +206,7 @@ examples:
186206
};
187207
- |
188208
#include <dt-bindings/clock/imx8mp-clock.h>
209+
#include <dt-bindings/reset/imx8mp-reset-audiomix.h>
189210
dsp_reserved: dsp@92400000 {
190211
reg = <0x92400000 0x1000000>;
191212
no-map;
@@ -220,5 +241,6 @@ examples:
220241
<&mu2 3 0>;
221242
memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>,
222243
<&dsp_vdev0vring1>, <&dsp_reserved>;
223-
fsl,dsp-ctrl = <&audio_blk_ctrl>;
244+
resets = <&audio_blk_ctrl IMX8MP_AUDIOMIX_DSP_RUNSTALL>;
245+
reset-names = "runstall";
224246
};

0 commit comments

Comments
 (0)