Skip to content

Commit e1bfdbc

Browse files
AngeloGioacchino Del Regnogregkh
authored andcommitted
serial: 8250_mtk: Fix register address for XON/XOFF character
The XON1/XOFF1 character registers are at offset 0xa0 and 0xa8 respectively, so we cannot use the definition in serial_port.h. Fixes: bdbd0a7 ("serial: 8250-mtk: modify baudrate setting") Signed-off-by: AngeloGioacchino Del Regno <[email protected]> Cc: stable <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 6f81fdd commit e1bfdbc

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

drivers/tty/serial/8250/8250_mtk.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,9 @@
5757
#define MTK_UART_FEATURE_SEL 39 /* Feature Selection register */
5858
#define MTK_UART_FEAT_NEWRMAP BIT(0) /* Use new register map */
5959

60+
#define MTK_UART_XON1 40 /* I/O: Xon character 1 */
61+
#define MTK_UART_XOFF1 42 /* I/O: Xoff character 1 */
62+
6063
#ifdef CONFIG_SERIAL_8250_DMA
6164
enum dma_rx_status {
6265
DMA_RX_START = 0,
@@ -278,8 +281,8 @@ static void mtk8250_set_flow_ctrl(struct uart_8250_port *up, int mode)
278281
(serial_in(up, MTK_UART_EFR) &
279282
(~(MTK_UART_EFR_HW_FC | MTK_UART_EFR_SW_FC_MASK))));
280283

281-
serial_out(up, UART_XON1, START_CHAR(port->state->port.tty));
282-
serial_out(up, UART_XOFF1, STOP_CHAR(port->state->port.tty));
284+
serial_out(up, MTK_UART_XON1, START_CHAR(port->state->port.tty));
285+
serial_out(up, MTK_UART_XOFF1, STOP_CHAR(port->state->port.tty));
283286
serial_out(up, UART_LCR, lcr);
284287
mtk8250_disable_intrs(up, MTK_UART_IER_CTSI|MTK_UART_IER_RTSI);
285288
mtk8250_enable_intrs(up, MTK_UART_IER_XOFFI);

0 commit comments

Comments
 (0)