Skip to content

Commit e1dc209

Browse files
John GarryMarc Zyngier
authored andcommitted
driver core: platform: Add extra error check in devm_platform_get_irqs_affinity()
The current check of nvec < minvec for nvec returned from platform_irq_count() will not detect a negative error code in nvec. This is because minvec is unsigned, and, as such, nvec is promoted to unsigned in that check, which will make it a huge number (if it contained -EPROBE_DEFER). In practice, an error should not occur in nvec for the only in-tree user, but add a check anyway. Fixes: e15f2fa ("driver core: platform: Add devm_platform_get_irqs_affinity()") Reported-by: Dan Carpenter <[email protected]> Signed-off-by: John Garry <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent d7f39c4 commit e1dc209

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/base/platform.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,8 @@ int devm_platform_get_irqs_affinity(struct platform_device *dev,
351351
return -ERANGE;
352352

353353
nvec = platform_irq_count(dev);
354+
if (nvec < 0)
355+
return nvec;
354356

355357
if (nvec < minvec)
356358
return -ENOSPC;

0 commit comments

Comments
 (0)