Skip to content

Commit e1f4616

Browse files
westeriandy-shev
authored andcommitted
platform/x86: intel_pmc_ipc: Make intel_pmc_gcr_update() static
This function is not called outside of intel_pmc_ipc.c so we can make it static instead. Signed-off-by: Mika Westerberg <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]>
1 parent 8b23656 commit e1f4616

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

arch/x86/include/asm/intel_pmc_ipc.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ int intel_pmc_s0ix_counter_read(u64 *data);
4040
int intel_pmc_gcr_read(u32 offset, u32 *data);
4141
int intel_pmc_gcr_read64(u32 offset, u64 *data);
4242
int intel_pmc_gcr_write(u32 offset, u32 data);
43-
int intel_pmc_gcr_update(u32 offset, u32 mask, u32 val);
4443

4544
#else
4645

@@ -81,11 +80,6 @@ static inline int intel_pmc_gcr_write(u32 offset, u32 data)
8180
return -EINVAL;
8281
}
8382

84-
static inline int intel_pmc_gcr_update(u32 offset, u32 mask, u32 val)
85-
{
86-
return -EINVAL;
87-
}
88-
8983
#endif /*CONFIG_INTEL_PMC_IPC*/
9084

9185
#endif

drivers/platform/x86/intel_pmc_ipc.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ EXPORT_SYMBOL_GPL(intel_pmc_gcr_write);
309309
*
310310
* Return: negative value on error or 0 on success.
311311
*/
312-
int intel_pmc_gcr_update(u32 offset, u32 mask, u32 val)
312+
static int intel_pmc_gcr_update(u32 offset, u32 mask, u32 val)
313313
{
314314
u32 new_val;
315315
int ret = 0;
@@ -339,7 +339,6 @@ int intel_pmc_gcr_update(u32 offset, u32 mask, u32 val)
339339
spin_unlock(&ipcdev.gcr_lock);
340340
return ret;
341341
}
342-
EXPORT_SYMBOL_GPL(intel_pmc_gcr_update);
343342

344343
static int update_no_reboot_bit(void *priv, bool set)
345344
{

0 commit comments

Comments
 (0)