Skip to content

Commit e26060e

Browse files
GustavoARSilvajoergroedel
authored andcommitted
iommu/qcom: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] KSPP#21 [3] commit 7649773 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Joerg Roedel <[email protected]>
1 parent f8788d8 commit e26060e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/iommu/qcom_iommu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ struct qcom_iommu_dev {
4848
void __iomem *local_base;
4949
u32 sec_id;
5050
u8 num_ctxs;
51-
struct qcom_iommu_ctx *ctxs[0]; /* indexed by asid-1 */
51+
struct qcom_iommu_ctx *ctxs[]; /* indexed by asid-1 */
5252
};
5353

5454
struct qcom_iommu_ctx {

0 commit comments

Comments
 (0)