Skip to content

Commit e2c85d8

Browse files
Jinjie RuanAndi Shyti
authored andcommitted
i2c: qcom-geni: Use IRQF_NO_AUTOEN flag in request_irq()
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 37692de ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller") Signed-off-by: Jinjie Ruan <[email protected]> Cc: <[email protected]> # v4.19+ Acked-by: Mukesh Kumar Savaliya <[email protected]> Reviewed-by: Vladimir Zapolskiy <[email protected]> Signed-off-by: Andi Shyti <[email protected]>
1 parent 1db4da5 commit e2c85d8

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/i2c/busses/i2c-qcom-geni.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -818,15 +818,13 @@ static int geni_i2c_probe(struct platform_device *pdev)
818818
init_completion(&gi2c->done);
819819
spin_lock_init(&gi2c->lock);
820820
platform_set_drvdata(pdev, gi2c);
821-
ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, 0,
821+
ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, IRQF_NO_AUTOEN,
822822
dev_name(dev), gi2c);
823823
if (ret) {
824824
dev_err(dev, "Request_irq failed:%d: err:%d\n",
825825
gi2c->irq, ret);
826826
return ret;
827827
}
828-
/* Disable the interrupt so that the system can enter low-power mode */
829-
disable_irq(gi2c->irq);
830828
i2c_set_adapdata(&gi2c->adap, gi2c);
831829
gi2c->adap.dev.parent = dev;
832830
gi2c->adap.dev.of_node = dev->of_node;

0 commit comments

Comments
 (0)