Skip to content

Commit e359c70

Browse files
committed
drm/sun4i: backend: Support alpha property on lowest plane
Unlike what we previously thought, only the per-pixel alpha is broken on the lowest plane and the per-plane alpha isn't. Remove the check on the alpha property being set on the lowest plane to reject a mode. Fixes: dcf496a ("drm/sun4i: sun4i: Introduce a quirk for lowest plane alpha support") Signed-off-by: Maxime Ripard <[email protected]> Reviewed-by: Chen-Yu Tsai <[email protected]> Cc: Paul Kocialkowski <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 0ee9f60 commit e359c70

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/gpu/drm/sun4i/sun4i_backend.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -589,8 +589,7 @@ static int sun4i_backend_atomic_check(struct sunxi_engine *engine,
589589

590590
/* We can't have an alpha plane at the lowest position */
591591
if (!backend->quirks->supports_lowest_plane_alpha &&
592-
(plane_states[0]->fb->format->has_alpha ||
593-
(plane_states[0]->alpha != DRM_BLEND_ALPHA_OPAQUE)))
592+
(plane_states[0]->alpha != DRM_BLEND_ALPHA_OPAQUE))
594593
return -EINVAL;
595594

596595
for (i = 1; i < num_planes; i++) {

0 commit comments

Comments
 (0)