Skip to content

Commit e41fc7c

Browse files
committed
Merge tag 'sound-5.13-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
Pull sound fixes from Takashi Iwai: "Two small changes have been cherry-picked as a last material for 5.13: a coverage after UMN revert action and a stale MAINTAINERS entry fix" * tag 'sound-5.13-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: MAINTAINERS: remove Timur Tabi from Freescale SOC sound drivers ASoC: rt5645: Avoid upgrading static warnings to errors
2 parents 44db63d + 5c6d4f9 commit e41fc7c

File tree

2 files changed

+11
-39
lines changed

2 files changed

+11
-39
lines changed

MAINTAINERS

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7354,7 +7354,6 @@ F: drivers/net/ethernet/freescale/fs_enet/
73547354
F: include/linux/fs_enet_pd.h
73557355

73567356
FREESCALE SOC SOUND DRIVERS
7357-
M: Timur Tabi <[email protected]>
73587357
M: Nicolin Chen <[email protected]>
73597358
M: Xiubo Li <[email protected]>
73607359
R: Fabio Estevam <[email protected]>

sound/soc/codecs/rt5645.c

Lines changed: 11 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -3388,62 +3388,40 @@ static int rt5645_probe(struct snd_soc_component *component)
33883388
{
33893389
struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component);
33903390
struct rt5645_priv *rt5645 = snd_soc_component_get_drvdata(component);
3391-
int ret = 0;
33923391

33933392
rt5645->component = component;
33943393

33953394
switch (rt5645->codec_type) {
33963395
case CODEC_TYPE_RT5645:
3397-
ret = snd_soc_dapm_new_controls(dapm,
3396+
snd_soc_dapm_new_controls(dapm,
33983397
rt5645_specific_dapm_widgets,
33993398
ARRAY_SIZE(rt5645_specific_dapm_widgets));
3400-
if (ret < 0)
3401-
goto exit;
3402-
3403-
ret = snd_soc_dapm_add_routes(dapm,
3399+
snd_soc_dapm_add_routes(dapm,
34043400
rt5645_specific_dapm_routes,
34053401
ARRAY_SIZE(rt5645_specific_dapm_routes));
3406-
if (ret < 0)
3407-
goto exit;
3408-
34093402
if (rt5645->v_id < 3) {
3410-
ret = snd_soc_dapm_add_routes(dapm,
3403+
snd_soc_dapm_add_routes(dapm,
34113404
rt5645_old_dapm_routes,
34123405
ARRAY_SIZE(rt5645_old_dapm_routes));
3413-
if (ret < 0)
3414-
goto exit;
34153406
}
34163407
break;
34173408
case CODEC_TYPE_RT5650:
3418-
ret = snd_soc_dapm_new_controls(dapm,
3409+
snd_soc_dapm_new_controls(dapm,
34193410
rt5650_specific_dapm_widgets,
34203411
ARRAY_SIZE(rt5650_specific_dapm_widgets));
3421-
if (ret < 0)
3422-
goto exit;
3423-
3424-
ret = snd_soc_dapm_add_routes(dapm,
3412+
snd_soc_dapm_add_routes(dapm,
34253413
rt5650_specific_dapm_routes,
34263414
ARRAY_SIZE(rt5650_specific_dapm_routes));
3427-
if (ret < 0)
3428-
goto exit;
34293415
break;
34303416
}
34313417

34323418
snd_soc_component_force_bias_level(component, SND_SOC_BIAS_OFF);
34333419

34343420
/* for JD function */
34353421
if (rt5645->pdata.jd_mode) {
3436-
ret = snd_soc_dapm_force_enable_pin(dapm, "JD Power");
3437-
if (ret < 0)
3438-
goto exit;
3439-
3440-
ret = snd_soc_dapm_force_enable_pin(dapm, "LDO2");
3441-
if (ret < 0)
3442-
goto exit;
3443-
3444-
ret = snd_soc_dapm_sync(dapm);
3445-
if (ret < 0)
3446-
goto exit;
3422+
snd_soc_dapm_force_enable_pin(dapm, "JD Power");
3423+
snd_soc_dapm_force_enable_pin(dapm, "LDO2");
3424+
snd_soc_dapm_sync(dapm);
34473425
}
34483426

34493427
if (rt5645->pdata.long_name)
@@ -3454,14 +3432,9 @@ static int rt5645_probe(struct snd_soc_component *component)
34543432
GFP_KERNEL);
34553433

34563434
if (!rt5645->eq_param)
3457-
ret = -ENOMEM;
3458-
exit:
3459-
/*
3460-
* If there was an error above, everything will be cleaned up by the
3461-
* caller if we return an error here. This will be done with a later
3462-
* call to rt5645_remove().
3463-
*/
3464-
return ret;
3435+
return -ENOMEM;
3436+
3437+
return 0;
34653438
}
34663439

34673440
static void rt5645_remove(struct snd_soc_component *component)

0 commit comments

Comments
 (0)