Skip to content

Commit e430c0e

Browse files
Mani-Sadhasivammartinkpetersen
authored andcommitted
scsi: ufs: qcom: Check the return value of ufs_qcom_power_up_sequence()
If ufs_qcom_power_up_sequence() fails, then it makes no sense to enable the lane clocks and continue ufshcd_hba_enable(). So let's check the return value of ufs_qcom_power_up_sequence(). Reviewed-by: Andrew Halaney <[email protected]> Signed-off-by: Manivannan Sadhasivam <[email protected]> Link: https://lore.kernel.org/r/[email protected] Tested-by: Andrew Halaney <[email protected]> # sa8775p-ride Signed-off-by: Martin K. Petersen <[email protected]>
1 parent d119547 commit e430c0e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/ufs/host/ufs-qcom.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,10 @@ static int ufs_qcom_hce_enable_notify(struct ufs_hba *hba,
417417

418418
switch (status) {
419419
case PRE_CHANGE:
420-
ufs_qcom_power_up_sequence(hba);
420+
err = ufs_qcom_power_up_sequence(hba);
421+
if (err)
422+
return err;
423+
421424
/*
422425
* The PHY PLL output is the source of tx/rx lane symbol
423426
* clocks, hence, enable the lane clocks only after PHY

0 commit comments

Comments
 (0)