Skip to content

Commit e44fd50

Browse files
committed
ksmbd: log that server is experimental at module load
While we are working through detailed security reviews of ksmbd server code we should remind users that it is an experimental module by adding a warning when the module loads. Currently the module shows as experimental in Kconfig and is disabled by default, but we don't want to confuse users. Although ksmbd passes a wide variety of the important functional tests (since initial focus had been largely on functional testing such as smbtorture, xfstests etc.), and ksmbd has added key security features (e.g. GCM256 encryption, Kerberos support), there are ongoing detailed reviews of the code base for path processing and network buffer decoding, and this patch reminds users that the module should be considered "experimental." Reviewed-by: Namjae Jeon <[email protected]> Reviewed-by: Paulo Alcantara (SUSE) <[email protected]> Reviewed-by: Ronnie Sahlberg <[email protected]> Signed-off-by: Steve French <[email protected]>
1 parent 707a63e commit e44fd50

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

fs/ksmbd/server.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -584,6 +584,9 @@ static int __init ksmbd_server_init(void)
584584
ret = ksmbd_workqueue_init();
585585
if (ret)
586586
goto err_crypto_destroy;
587+
588+
pr_warn_once("The ksmbd server is experimental, use at your own risk.\n");
589+
587590
return 0;
588591

589592
err_crypto_destroy:

0 commit comments

Comments
 (0)