Skip to content

Commit e463625

Browse files
Heiko Stuebnermmind
authored andcommitted
arm64: dts: rockchip: move reset to dedicated eth-phy node on ringneck
Using snps,reset-* properties to handle the ethernet-phy resets is deprecated and instead a real phy node should be used. Move the Ringneck phy-reset properties to such a node Signed-off-by: Heiko Stuebner <[email protected]> Reviewed-by: Quentin Schulz <[email protected]> Tested-by: Quentin Schulz <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Heiko Stuebner <[email protected]>
1 parent ede4837 commit e463625

File tree

1 file changed

+19
-3
lines changed

1 file changed

+19
-3
lines changed

arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,7 @@
8383

8484
/* On-module TI DP83825I PHY but no connector, enable in carrierboard */
8585
&gmac {
86-
snps,reset-gpio = <&gpio3 RK_PB0 GPIO_ACTIVE_LOW>;
87-
snps,reset-active-low;
88-
snps,reset-delays-us = <0 50000 50000>;
86+
phy-handle = <&dp83825>;
8987
phy-supply = <&vcc_3v3>;
9088
clock_in_out = "output";
9189
};
@@ -344,13 +342,31 @@
344342
status = "okay";
345343
};
346344

345+
&mdio {
346+
dp83825: ethernet-phy@0 {
347+
compatible = "ethernet-phy-ieee802.3-c22";
348+
reg = <0x0>;
349+
pinctrl-names = "default";
350+
pinctrl-0 = <&phy_rst>;
351+
reset-assert-us = <50000>;
352+
reset-deassert-us = <50000>;
353+
reset-gpios = <&gpio3 RK_PB0 GPIO_ACTIVE_LOW>;
354+
};
355+
};
356+
347357
&pinctrl {
348358
emmc {
349359
emmc_reset: emmc-reset {
350360
rockchip,pins = <1 RK_PB3 RK_FUNC_GPIO &pcfg_pull_none>;
351361
};
352362
};
353363

364+
ethernet {
365+
phy_rst: phy-rst {
366+
rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
367+
};
368+
};
369+
354370
leds {
355371
module_led_pin: module-led-pin {
356372
rockchip,pins = <1 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;

0 commit comments

Comments
 (0)