Skip to content

Commit e4860f0

Browse files
swahlhpehansendc
authored andcommitted
x86/platform/uv: Fix printed information in calc_mmioh_map
Fix incorrect mask names and values in calc_mmioh_map() that caused it to print wrong NASID information. And an unused blade position is not an error condition, but will yield an invalid NASID value, so change the invalid NASID message from an error to a debug message. Signed-off-by: Steve Wahl <[email protected]> Signed-off-by: Dave Hansen <[email protected]> Link: https://lore.kernel.org/all/20230519190752.3297140-4-steve.wahl%40hpe.com
1 parent 8c646ce commit e4860f0

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

arch/x86/kernel/apic/x2apic_uv_x.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1022,31 +1022,31 @@ static void __init calc_mmioh_map(enum mmioh_arch index,
10221022
switch (index) {
10231023
case UVY_MMIOH0:
10241024
mmr = UVH_RH10_GAM_MMIOH_REDIRECT_CONFIG0;
1025-
nasid_mask = UVH_RH10_GAM_MMIOH_OVERLAY_CONFIG0_BASE_MASK;
1025+
nasid_mask = UVYH_RH10_GAM_MMIOH_REDIRECT_CONFIG0_NASID_MASK;
10261026
n = UVH_RH10_GAM_MMIOH_REDIRECT_CONFIG0_DEPTH;
10271027
min_nasid = min_pnode;
10281028
max_nasid = max_pnode;
10291029
mapped = 1;
10301030
break;
10311031
case UVY_MMIOH1:
10321032
mmr = UVH_RH10_GAM_MMIOH_REDIRECT_CONFIG1;
1033-
nasid_mask = UVH_RH10_GAM_MMIOH_OVERLAY_CONFIG1_BASE_MASK;
1033+
nasid_mask = UVYH_RH10_GAM_MMIOH_REDIRECT_CONFIG1_NASID_MASK;
10341034
n = UVH_RH10_GAM_MMIOH_REDIRECT_CONFIG1_DEPTH;
10351035
min_nasid = min_pnode;
10361036
max_nasid = max_pnode;
10371037
mapped = 1;
10381038
break;
10391039
case UVX_MMIOH0:
10401040
mmr = UVH_RH_GAM_MMIOH_REDIRECT_CONFIG0;
1041-
nasid_mask = UVH_RH_GAM_MMIOH_OVERLAY_CONFIG0_BASE_MASK;
1041+
nasid_mask = UVH_RH_GAM_MMIOH_REDIRECT_CONFIG0_NASID_MASK;
10421042
n = UVH_RH_GAM_MMIOH_REDIRECT_CONFIG0_DEPTH;
10431043
min_nasid = min_pnode * 2;
10441044
max_nasid = max_pnode * 2;
10451045
mapped = 1;
10461046
break;
10471047
case UVX_MMIOH1:
10481048
mmr = UVH_RH_GAM_MMIOH_REDIRECT_CONFIG1;
1049-
nasid_mask = UVH_RH_GAM_MMIOH_OVERLAY_CONFIG1_BASE_MASK;
1049+
nasid_mask = UVH_RH_GAM_MMIOH_REDIRECT_CONFIG1_NASID_MASK;
10501050
n = UVH_RH_GAM_MMIOH_REDIRECT_CONFIG1_DEPTH;
10511051
min_nasid = min_pnode * 2;
10521052
max_nasid = max_pnode * 2;
@@ -1072,8 +1072,9 @@ static void __init calc_mmioh_map(enum mmioh_arch index,
10721072

10731073
/* Invalid NASID check */
10741074
if (nasid < min_nasid || max_nasid < nasid) {
1075-
pr_err("UV:%s:Invalid NASID:%x (range:%x..%x)\n",
1076-
__func__, index, min_nasid, max_nasid);
1075+
/* Not an error: unused table entries get "poison" values */
1076+
pr_debug("UV:%s:Invalid NASID(%x):%x (range:%x..%x)\n",
1077+
__func__, index, nasid, min_nasid, max_nasid);
10771078
nasid = -1;
10781079
}
10791080

0 commit comments

Comments
 (0)