Skip to content

Commit e4ad153

Browse files
aduggan-synadtor
authored andcommitted
Input: synaptics-rmi4 - set reduced reporting mode only when requested
The previous patch "c5ccf2ad3d33 (Input: synaptics-rmi4 - switch to reduced reporting mode)" enabled reduced reporting mode unintentionally on some devices, if the firmware was configured with default Delta X/Y threshold values. The result unintentionally degrade the performance of some touchpads. This patch checks to see that the driver is modifying the delta X/Y thresholds before modifying the reporting mode. Signed-off-by: Andrew Duggan <[email protected]> Fixes: c5ccf2a ("Input: synaptics-rmi4 - switch to reduced reporting mode") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dmitry Torokhov <[email protected]>
1 parent 1369d0a commit e4ad153

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/input/rmi4/rmi_f11.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1203,8 +1203,8 @@ static int rmi_f11_initialize(struct rmi_function *fn)
12031203
* If distance threshold values are set, switch to reduced reporting
12041204
* mode so they actually get used by the controller.
12051205
*/
1206-
if (ctrl->ctrl0_11[RMI_F11_DELTA_X_THRESHOLD] ||
1207-
ctrl->ctrl0_11[RMI_F11_DELTA_Y_THRESHOLD]) {
1206+
if (sensor->axis_align.delta_x_threshold ||
1207+
sensor->axis_align.delta_y_threshold) {
12081208
ctrl->ctrl0_11[0] &= ~RMI_F11_REPORT_MODE_MASK;
12091209
ctrl->ctrl0_11[0] |= RMI_F11_REPORT_MODE_REDUCED;
12101210
}

0 commit comments

Comments
 (0)