Skip to content

Commit e4ae473

Browse files
Christoph Hellwigaxboe
authored andcommitted
udf: use sb_bdev_nr_blocks
Use the sb_bdev_nr_blocks helper instead of open coding it. Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Kees Cook <[email protected]> Reviewed-by: Jan Kara <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 2ffae49 commit e4ae473

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

fs/udf/lowlevel.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,15 @@ unsigned int udf_get_last_session(struct super_block *sb)
4747

4848
unsigned long udf_get_last_block(struct super_block *sb)
4949
{
50-
struct block_device *bdev = sb->s_bdev;
51-
struct cdrom_device_info *cdi = disk_to_cdi(bdev->bd_disk);
50+
struct cdrom_device_info *cdi = disk_to_cdi(sb->s_bdev->bd_disk);
5251
unsigned long lblock = 0;
5352

5453
/*
5554
* The cdrom layer call failed or returned obviously bogus value?
5655
* Try using the device size...
5756
*/
5857
if (!cdi || cdrom_get_last_written(cdi, &lblock) || lblock == 0)
59-
lblock = i_size_read(bdev->bd_inode) >> sb->s_blocksize_bits;
58+
lblock = sb_bdev_nr_blocks(sb);
6059

6160
if (lblock)
6261
return lblock - 1;

fs/udf/super.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1175,8 +1175,7 @@ static int udf_load_vat(struct super_block *sb, int p_index, int type1_index)
11751175
struct udf_inode_info *vati;
11761176
uint32_t pos;
11771177
struct virtualAllocationTable20 *vat20;
1178-
sector_t blocks = i_size_read(sb->s_bdev->bd_inode) >>
1179-
sb->s_blocksize_bits;
1178+
sector_t blocks = sb_bdev_nr_blocks(sb);
11801179

11811180
udf_find_vat_block(sb, p_index, type1_index, sbi->s_last_block);
11821181
if (!sbi->s_vat_inode &&
@@ -1838,8 +1837,7 @@ static int udf_check_anchor_block(struct super_block *sb, sector_t block,
18381837
int ret;
18391838

18401839
if (UDF_QUERY_FLAG(sb, UDF_FLAG_VARCONV) &&
1841-
udf_fixed_to_variable(block) >=
1842-
i_size_read(sb->s_bdev->bd_inode) >> sb->s_blocksize_bits)
1840+
udf_fixed_to_variable(block) >= sb_bdev_nr_blocks(sb))
18431841
return -EAGAIN;
18441842

18451843
bh = udf_read_tagged(sb, block, block, &ident);
@@ -1901,8 +1899,7 @@ static int udf_scan_anchors(struct super_block *sb, sector_t *lastblock,
19011899
last[last_count++] = *lastblock - 152;
19021900

19031901
for (i = 0; i < last_count; i++) {
1904-
if (last[i] >= i_size_read(sb->s_bdev->bd_inode) >>
1905-
sb->s_blocksize_bits)
1902+
if (last[i] >= sb_bdev_nr_blocks(sb))
19061903
continue;
19071904
ret = udf_check_anchor_block(sb, last[i], fileset);
19081905
if (ret != -EAGAIN) {

0 commit comments

Comments
 (0)