Skip to content

Commit e55c678

Browse files
floatiouskwilczynski
authored andcommitted
PCI: dw-rockchip: Endpoint mode cannot raise INTx interrupts
Neither RK3568 or RK3588 supports INTx interrupts. Since epc_features is zero initialized, this is strictly not needed. However, setting intx_capable explicitly to false makes it more clear that neither RK3568 or RK3588 supports INTx interrupts. No functional change. Signed-off-by: Niklas Cassel <[email protected]> Signed-off-by: Krzysztof Wilczyński <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 4b313c6 commit e55c678

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/pci/controller/dwc/pcie-dw-rockchip.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@ static const struct pci_epc_features rockchip_pcie_epc_features_rk3568 = {
272272
.linkup_notifier = true,
273273
.msi_capable = true,
274274
.msix_capable = true,
275+
.intx_capable = false,
275276
.align = SZ_64K,
276277
.bar[BAR_0] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
277278
.bar[BAR_1] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
@@ -292,6 +293,7 @@ static const struct pci_epc_features rockchip_pcie_epc_features_rk3588 = {
292293
.linkup_notifier = true,
293294
.msi_capable = true,
294295
.msix_capable = true,
296+
.intx_capable = false,
295297
.align = SZ_64K,
296298
.bar[BAR_0] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
297299
.bar[BAR_1] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },

0 commit comments

Comments
 (0)