Skip to content

Commit e5ac171

Browse files
Matthew Wilcox (Oracle)Andreas Gruenbacher
authored andcommitted
gfs2: Remove gfs2_jdata_writepage()
There are no remaining callers of gfs2_jdata_writepage() other than vmscan, which is known to do more harm than good. Signed-off-by: Matthew Wilcox (Oracle) <[email protected]> Signed-off-by: Andreas Gruenbacher <[email protected]>
1 parent 8d39197 commit e5ac171

File tree

1 file changed

+0
-30
lines changed

1 file changed

+0
-30
lines changed

fs/gfs2/aops.c

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -138,35 +138,6 @@ static int __gfs2_jdata_write_folio(struct folio *folio,
138138
return gfs2_write_jdata_folio(folio, wbc);
139139
}
140140

141-
/**
142-
* gfs2_jdata_writepage - Write complete page
143-
* @page: Page to write
144-
* @wbc: The writeback control
145-
*
146-
* Returns: errno
147-
*
148-
*/
149-
150-
static int gfs2_jdata_writepage(struct page *page, struct writeback_control *wbc)
151-
{
152-
struct folio *folio = page_folio(page);
153-
struct inode *inode = page->mapping->host;
154-
struct gfs2_inode *ip = GFS2_I(inode);
155-
struct gfs2_sbd *sdp = GFS2_SB(inode);
156-
157-
if (gfs2_assert_withdraw(sdp, ip->i_gl->gl_state == LM_ST_EXCLUSIVE))
158-
goto out;
159-
if (folio_test_checked(folio) || current->journal_info)
160-
goto out_ignore;
161-
return __gfs2_jdata_write_folio(folio, wbc);
162-
163-
out_ignore:
164-
folio_redirty_for_writepage(wbc, folio);
165-
out:
166-
folio_unlock(folio);
167-
return 0;
168-
}
169-
170141
/**
171142
* gfs2_writepages - Write a bunch of dirty pages back to disk
172143
* @mapping: The mapping to write
@@ -748,7 +719,6 @@ static const struct address_space_operations gfs2_aops = {
748719
};
749720

750721
static const struct address_space_operations gfs2_jdata_aops = {
751-
.writepage = gfs2_jdata_writepage,
752722
.writepages = gfs2_jdata_writepages,
753723
.read_folio = gfs2_read_folio,
754724
.readahead = gfs2_readahead,

0 commit comments

Comments
 (0)