Skip to content

Commit e5acf0e

Browse files
committed
Merge tag 'ntb-5.10' of git://github.com/jonmason/ntb
Pull NTB fixes from Jon Mason. * tag 'ntb-5.10' of git://github.com/jonmason/ntb: NTB: Use struct_size() helper in devm_kzalloc() ntb: intel: Fix memleak in intel_ntb_pci_probe NTB: hw: amd: fix an issue about leak system resources
2 parents 0746c4a + b8e2c8b commit e5acf0e

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

drivers/ntb/hw/amd/ntb_hw_amd.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1203,6 +1203,7 @@ static int amd_ntb_init_pci(struct amd_ntb_dev *ndev,
12031203

12041204
err_dma_mask:
12051205
pci_clear_master(pdev);
1206+
pci_release_regions(pdev);
12061207
err_pci_regions:
12071208
pci_disable_device(pdev);
12081209
err_pci_enable:

drivers/ntb/hw/intel/ntb_hw_gen1.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1893,7 +1893,7 @@ static int intel_ntb_pci_probe(struct pci_dev *pdev,
18931893
goto err_init_dev;
18941894
} else {
18951895
rc = -EINVAL;
1896-
goto err_ndev;
1896+
goto err_init_pci;
18971897
}
18981898

18991899
ndev_reset_unsafe_flags(ndev);

drivers/ntb/test/ntb_msi_test.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,6 @@ static void ntb_msit_remove_dbgfs(struct ntb_msit_ctx *nm)
319319
static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb)
320320
{
321321
struct ntb_msit_ctx *nm;
322-
size_t struct_size;
323322
int peers;
324323
int ret;
325324

@@ -352,9 +351,7 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb)
352351
return ret;
353352
}
354353

355-
struct_size = sizeof(*nm) + sizeof(*nm->peers) * peers;
356-
357-
nm = devm_kzalloc(&ntb->dev, struct_size, GFP_KERNEL);
354+
nm = devm_kzalloc(&ntb->dev, struct_size(nm, peers, peers), GFP_KERNEL);
358355
if (!nm)
359356
return -ENOMEM;
360357

0 commit comments

Comments
 (0)