Skip to content

Commit e5c624f

Browse files
committed
tracing: Have event inject files inc the trace array ref count
The event inject files add events for a specific trace array. For an instance, if the file is opened and the instance is deleted, reading or writing to the file will cause a use after free. Up the ref count of the trace_array when a event inject file is opened. Link: https://lkml.kernel.org/r/[email protected] Link: https://lore.kernel.org/all/[email protected]/ Cc: [email protected] Cc: Masami Hiramatsu <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Andrew Morton <[email protected]> Cc: Zheng Yejian <[email protected]> Fixes: 6c3edaf ("tracing: Introduce trace event injection") Tested-by: Linux Kernel Functional Testing <[email protected]> Tested-by: Naresh Kamboju <[email protected]> Signed-off-by: Steven Rostedt (Google) <[email protected]>
1 parent 7e2cfbd commit e5c624f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

kernel/trace/trace_events_inject.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,8 @@ event_inject_read(struct file *file, char __user *buf, size_t size,
328328
}
329329

330330
const struct file_operations event_inject_fops = {
331-
.open = tracing_open_generic,
331+
.open = tracing_open_file_tr,
332332
.read = event_inject_read,
333333
.write = event_inject_write,
334+
.release = tracing_release_file_tr,
334335
};

0 commit comments

Comments
 (0)