Skip to content

Commit e5e9a43

Browse files
Vladimir ZapolskiyGao Xiang
authored andcommitted
erofs: remove unused tag argument while registering a workgroup
All workgroups are registered with tag value set to 0, to simplify erofs_register_workgroup() interface the tag argument can be removed, if its only value is sent down to the function body. Signed-off-by: Vladimir Zapolskiy <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Chao Yu <[email protected]> Signed-off-by: Gao Xiang <[email protected]>
1 parent 997626d commit e5e9a43

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

fs/erofs/internal.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,7 @@ int erofs_workgroup_put(struct erofs_workgroup *grp);
403403
struct erofs_workgroup *erofs_find_workgroup(struct super_block *sb,
404404
pgoff_t index);
405405
int erofs_register_workgroup(struct super_block *sb,
406-
struct erofs_workgroup *grp, bool tag);
406+
struct erofs_workgroup *grp);
407407
void erofs_workgroup_free_rcu(struct erofs_workgroup *grp);
408408
void erofs_shrinker_register(struct super_block *sb);
409409
void erofs_shrinker_unregister(struct super_block *sb);

fs/erofs/utils.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,7 @@ struct erofs_workgroup *erofs_find_workgroup(struct super_block *sb,
8383
}
8484

8585
int erofs_register_workgroup(struct super_block *sb,
86-
struct erofs_workgroup *grp,
87-
bool tag)
86+
struct erofs_workgroup *grp)
8887
{
8988
struct erofs_sb_info *sbi;
9089
int err;
@@ -102,7 +101,7 @@ int erofs_register_workgroup(struct super_block *sb,
102101
sbi = EROFS_SB(sb);
103102
xa_lock(&sbi->workstn_tree);
104103

105-
grp = xa_tag_pointer(grp, tag);
104+
grp = xa_tag_pointer(grp, 0);
106105

107106
/*
108107
* Bump up reference count before making this workgroup

fs/erofs/zdata.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ static int z_erofs_register_collection(struct z_erofs_collector *clt,
437437
*/
438438
mutex_trylock(&cl->lock);
439439

440-
err = erofs_register_workgroup(inode->i_sb, &pcl->obj, 0);
440+
err = erofs_register_workgroup(inode->i_sb, &pcl->obj);
441441
if (err) {
442442
mutex_unlock(&cl->lock);
443443
kmem_cache_free(pcluster_cachep, pcl);

0 commit comments

Comments
 (0)