Skip to content

Commit e5f3205

Browse files
rockosovjic23
authored andcommitted
iio:accel:bma180: rearrange iio trigger get and register
IIO trigger interface function iio_trigger_get() should be called after iio_trigger_register() (or its devm analogue) strictly, because of iio_trigger_get() acquires module refcnt based on the trigger->owner pointer, which is initialized inside iio_trigger_register() to THIS_MODULE. If this call order is wrong, the next iio_trigger_put() (from sysfs callback or "delete module" path) will dereference "default" module refcnt, which is incorrect behaviour. Fixes: 0668a4e ("iio: accel: bma180: Fix indio_dev->trig assignment") Signed-off-by: Dmitry Rokosov <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Cc: <[email protected]> Signed-off-by: Jonathan Cameron <[email protected]>
1 parent 9decacd commit e5f3205

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/iio/accel/bma180.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1006,11 +1006,12 @@ static int bma180_probe(struct i2c_client *client,
10061006

10071007
data->trig->ops = &bma180_trigger_ops;
10081008
iio_trigger_set_drvdata(data->trig, indio_dev);
1009-
indio_dev->trig = iio_trigger_get(data->trig);
10101009

10111010
ret = iio_trigger_register(data->trig);
10121011
if (ret)
10131012
goto err_trigger_free;
1013+
1014+
indio_dev->trig = iio_trigger_get(data->trig);
10141015
}
10151016

10161017
ret = iio_triggered_buffer_setup(indio_dev, NULL,

0 commit comments

Comments
 (0)