Skip to content

Commit e63adec

Browse files
krzkSteven Price
authored andcommitted
drm/panfrost: Reduce the amount of logs on deferred probe
There is no point to print deferred probe (and its failures to get resources) as an error. Also there is no need to print regulator errors twice. In case of multiple probe tries this would pollute the dmesg. Signed-off-by: Krzysztof Kozlowski <[email protected]> Reviewed-by: Steven Price <[email protected]> Signed-off-by: Steven Price <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 2aae8ed commit e63adec

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/gpu/drm/panfrost/panfrost_device.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
101101
pfdev->comp->num_supplies,
102102
pfdev->regulators);
103103
if (ret < 0) {
104-
dev_err(pfdev->dev, "failed to get regulators: %d\n", ret);
104+
if (ret != -EPROBE_DEFER)
105+
dev_err(pfdev->dev, "failed to get regulators: %d\n",
106+
ret);
105107
return ret;
106108
}
107109

@@ -213,10 +215,8 @@ int panfrost_device_init(struct panfrost_device *pfdev)
213215
}
214216

215217
err = panfrost_regulator_init(pfdev);
216-
if (err) {
217-
dev_err(pfdev->dev, "regulator init failed %d\n", err);
218+
if (err)
218219
goto err_out0;
219-
}
220220

221221
err = panfrost_reset_init(pfdev);
222222
if (err) {

0 commit comments

Comments
 (0)