Skip to content

Commit e655c81

Browse files
committed
Merge tag 'fixes_for_v5.15-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
Pull misc filesystem fixes from Jan Kara: "A for ext2 sleep in atomic context in case of some fs problems and a cleanup of an invalidate_lock initialization" * tag 'fixes_for_v5.15-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs: ext2: fix sleeping in atomic bugs on error mm: Fully initialize invalidate_lock, amend lock class later
2 parents a801695 + 372d1f3 commit e655c81

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

fs/ext2/balloc.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,21 +48,19 @@ struct ext2_group_desc * ext2_get_group_desc(struct super_block * sb,
4848
struct ext2_sb_info *sbi = EXT2_SB(sb);
4949

5050
if (block_group >= sbi->s_groups_count) {
51-
ext2_error (sb, "ext2_get_group_desc",
52-
"block_group >= groups_count - "
53-
"block_group = %d, groups_count = %lu",
54-
block_group, sbi->s_groups_count);
51+
WARN(1, "block_group >= groups_count - "
52+
"block_group = %d, groups_count = %lu",
53+
block_group, sbi->s_groups_count);
5554

5655
return NULL;
5756
}
5857

5958
group_desc = block_group >> EXT2_DESC_PER_BLOCK_BITS(sb);
6059
offset = block_group & (EXT2_DESC_PER_BLOCK(sb) - 1);
6160
if (!sbi->s_group_desc[group_desc]) {
62-
ext2_error (sb, "ext2_get_group_desc",
63-
"Group descriptor not loaded - "
64-
"block_group = %d, group_desc = %lu, desc = %lu",
65-
block_group, group_desc, offset);
61+
WARN(1, "Group descriptor not loaded - "
62+
"block_group = %d, group_desc = %lu, desc = %lu",
63+
block_group, group_desc, offset);
6664
return NULL;
6765
}
6866

fs/inode.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,10 @@ int inode_init_always(struct super_block *sb, struct inode *inode)
190190
mapping_set_gfp_mask(mapping, GFP_HIGHUSER_MOVABLE);
191191
mapping->private_data = NULL;
192192
mapping->writeback_index = 0;
193-
__init_rwsem(&mapping->invalidate_lock, "mapping.invalidate_lock",
194-
&sb->s_type->invalidate_lock_key);
193+
init_rwsem(&mapping->invalidate_lock);
194+
lockdep_set_class_and_name(&mapping->invalidate_lock,
195+
&sb->s_type->invalidate_lock_key,
196+
"mapping.invalidate_lock");
195197
inode->i_private = NULL;
196198
inode->i_mapping = mapping;
197199
INIT_HLIST_HEAD(&inode->i_dentry); /* buggered by rcu freeing */

0 commit comments

Comments
 (0)