Skip to content

Commit e69709f

Browse files
digetxvireshk
authored andcommitted
opp: Add more resource-managed variants of dev_pm_opp_of_add_table()
Add resource-managed variants of dev_pm_opp_of_add_table_indexed() and dev_pm_opp_of_add_table_noclk(), allowing drivers to remove boilerplate code. Signed-off-by: Dmitry Osipenko <[email protected]> [ Viresh: Added underscore to devm_of_add_table_indexed() ] Signed-off-by: Viresh Kumar <[email protected]>
1 parent 3734b9f commit e69709f

File tree

2 files changed

+51
-7
lines changed

2 files changed

+51
-7
lines changed

drivers/opp/of.c

Lines changed: 39 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1081,6 +1081,17 @@ static void devm_pm_opp_of_table_release(void *data)
10811081
dev_pm_opp_of_remove_table(data);
10821082
}
10831083

1084+
static int _devm_of_add_table_indexed(struct device *dev, int index, bool getclk)
1085+
{
1086+
int ret;
1087+
1088+
ret = _of_add_table_indexed(dev, index, getclk);
1089+
if (ret)
1090+
return ret;
1091+
1092+
return devm_add_action_or_reset(dev, devm_pm_opp_of_table_release, dev);
1093+
}
1094+
10841095
/**
10851096
* devm_pm_opp_of_add_table() - Initialize opp table from device tree
10861097
* @dev: device pointer used to lookup OPP table.
@@ -1102,13 +1113,7 @@ static void devm_pm_opp_of_table_release(void *data)
11021113
*/
11031114
int devm_pm_opp_of_add_table(struct device *dev)
11041115
{
1105-
int ret;
1106-
1107-
ret = dev_pm_opp_of_add_table(dev);
1108-
if (ret)
1109-
return ret;
1110-
1111-
return devm_add_action_or_reset(dev, devm_pm_opp_of_table_release, dev);
1116+
return _devm_of_add_table_indexed(dev, 0, true);
11121117
}
11131118
EXPORT_SYMBOL_GPL(devm_pm_opp_of_add_table);
11141119

@@ -1151,6 +1156,19 @@ int dev_pm_opp_of_add_table_indexed(struct device *dev, int index)
11511156
}
11521157
EXPORT_SYMBOL_GPL(dev_pm_opp_of_add_table_indexed);
11531158

1159+
/**
1160+
* devm_pm_opp_of_add_table_indexed() - Initialize indexed opp table from device tree
1161+
* @dev: device pointer used to lookup OPP table.
1162+
* @index: Index number.
1163+
*
1164+
* This is a resource-managed variant of dev_pm_opp_of_add_table_indexed().
1165+
*/
1166+
int devm_pm_opp_of_add_table_indexed(struct device *dev, int index)
1167+
{
1168+
return _devm_of_add_table_indexed(dev, index, true);
1169+
}
1170+
EXPORT_SYMBOL_GPL(devm_pm_opp_of_add_table_indexed);
1171+
11541172
/**
11551173
* dev_pm_opp_of_add_table_noclk() - Initialize indexed opp table from device
11561174
* tree without getting clk for device.
@@ -1169,6 +1187,20 @@ int dev_pm_opp_of_add_table_noclk(struct device *dev, int index)
11691187
}
11701188
EXPORT_SYMBOL_GPL(dev_pm_opp_of_add_table_noclk);
11711189

1190+
/**
1191+
* devm_pm_opp_of_add_table_noclk() - Initialize indexed opp table from device
1192+
* tree without getting clk for device.
1193+
* @dev: device pointer used to lookup OPP table.
1194+
* @index: Index number.
1195+
*
1196+
* This is a resource-managed variant of dev_pm_opp_of_add_table_noclk().
1197+
*/
1198+
int devm_pm_opp_of_add_table_noclk(struct device *dev, int index)
1199+
{
1200+
return _devm_of_add_table_indexed(dev, index, false);
1201+
}
1202+
EXPORT_SYMBOL_GPL(devm_pm_opp_of_add_table_noclk);
1203+
11721204
/* CPU device specific helpers */
11731205

11741206
/**

include/linux/pm_opp.h

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,9 @@ static inline int dev_pm_opp_sync_regulators(struct device *dev)
439439
#if defined(CONFIG_PM_OPP) && defined(CONFIG_OF)
440440
int dev_pm_opp_of_add_table(struct device *dev);
441441
int dev_pm_opp_of_add_table_indexed(struct device *dev, int index);
442+
int devm_pm_opp_of_add_table_indexed(struct device *dev, int index);
442443
int dev_pm_opp_of_add_table_noclk(struct device *dev, int index);
444+
int devm_pm_opp_of_add_table_noclk(struct device *dev, int index);
443445
void dev_pm_opp_of_remove_table(struct device *dev);
444446
int devm_pm_opp_of_add_table(struct device *dev);
445447
int dev_pm_opp_of_cpumask_add_table(const struct cpumask *cpumask);
@@ -465,11 +467,21 @@ static inline int dev_pm_opp_of_add_table_indexed(struct device *dev, int index)
465467
return -EOPNOTSUPP;
466468
}
467469

470+
static inline int devm_pm_opp_of_add_table_indexed(struct device *dev, int index)
471+
{
472+
return -EOPNOTSUPP;
473+
}
474+
468475
static inline int dev_pm_opp_of_add_table_noclk(struct device *dev, int index)
469476
{
470477
return -EOPNOTSUPP;
471478
}
472479

480+
static inline int devm_pm_opp_of_add_table_noclk(struct device *dev, int index)
481+
{
482+
return -EOPNOTSUPP;
483+
}
484+
473485
static inline void dev_pm_opp_of_remove_table(struct device *dev)
474486
{
475487
}

0 commit comments

Comments
 (0)