Skip to content

Commit e6af9b0

Browse files
ambarusvinodkoul
authored andcommitted
dmaengine: at_xdmac: Start transfer for cyclic channels in issue_pending
Cyclic channels must too call issue_pending in order to start a transfer. Start the transfer in issue_pending regardless of the type of channel. This wrongly worked before, because in the past the transfer was started at tx_submit level when only a desc in the transfer list. Fixes: e1f7c9e ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver") Signed-off-by: Tudor Ambarus <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent bccfb96 commit e6af9b0

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

drivers/dma/at_xdmac.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1778,11 +1778,9 @@ static void at_xdmac_issue_pending(struct dma_chan *chan)
17781778

17791779
dev_dbg(chan2dev(&atchan->chan), "%s\n", __func__);
17801780

1781-
if (!at_xdmac_chan_is_cyclic(atchan)) {
1782-
spin_lock_irqsave(&atchan->lock, flags);
1783-
at_xdmac_advance_work(atchan);
1784-
spin_unlock_irqrestore(&atchan->lock, flags);
1785-
}
1781+
spin_lock_irqsave(&atchan->lock, flags);
1782+
at_xdmac_advance_work(atchan);
1783+
spin_unlock_irqrestore(&atchan->lock, flags);
17861784

17871785
return;
17881786
}

0 commit comments

Comments
 (0)