Skip to content

Commit e6d237f

Browse files
Enric Balletbo i Serrammind
authored andcommitted
arm64: dts: rockchip: Update DWC3 modules on RK3399 SoCs
As per binding documentation [1], the DWC3 core should have the "ref", "bus_early" and "suspend" clocks. As explained in the binding, those clocks are required for new platforms but not for existing platforms before commit fe8abf3 ("usb: dwc3: support clocks and resets for DWC3 core"). However, as those clocks are really treated as required, this ends with having some annoying messages when the "rockchip,rk3399-dwc3" is used: [ 1.724107] dwc3 fe800000.dwc3: Failed to get clk 'ref': -2 [ 1.731893] dwc3 fe900000.dwc3: Failed to get clk 'ref': -2 [ 2.495937] dwc3 fe800000.dwc3: Failed to get clk 'ref': -2 [ 2.647239] dwc3 fe900000.dwc3: Failed to get clk 'ref': -2 In order to remove those annoying messages, update the DWC3 hardware module node and add all the required clocks. With this change, both, the glue node and the DWC3 core node, have the clocks defined, but that's not really a problem and there isn't a side effect on do this. So, we can get rid of the annoying get clk error messages. [1] Documentation/devicetree/bindings/usb/dwc3.txt Signed-off-by: Enric Balletbo i Serra <[email protected]> Signed-off-by: Heiko Stuebner <[email protected]>
1 parent c9a8af8 commit e6d237f

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

arch/arm64/boot/dts/rockchip/rk3399.dtsi

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -414,6 +414,9 @@
414414
compatible = "snps,dwc3";
415415
reg = <0x0 0xfe800000 0x0 0x100000>;
416416
interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH 0>;
417+
clocks = <&cru SCLK_USB3OTG0_REF>, <&cru ACLK_USB3OTG0>,
418+
<&cru SCLK_USB3OTG0_SUSPEND>;
419+
clock-names = "ref", "bus_early", "suspend";
417420
dr_mode = "otg";
418421
phys = <&u2phy0_otg>, <&tcphy0_usb3>;
419422
phy-names = "usb2-phy", "usb3-phy";
@@ -447,6 +450,9 @@
447450
compatible = "snps,dwc3";
448451
reg = <0x0 0xfe900000 0x0 0x100000>;
449452
interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH 0>;
453+
clocks = <&cru SCLK_USB3OTG1_REF>, <&cru ACLK_USB3OTG1>,
454+
<&cru SCLK_USB3OTG1_SUSPEND>;
455+
clock-names = "ref", "bus_early", "suspend";
450456
dr_mode = "otg";
451457
phys = <&u2phy1_otg>, <&tcphy1_usb3>;
452458
phy-names = "usb2-phy", "usb3-phy";

0 commit comments

Comments
 (0)