Skip to content

Commit e6e9a9a

Browse files
covanambjorn-helgaas
authored andcommitted
PCI: hotplug: Document unchecked return value of pci_hp_add_bridge()
Some hotplug drivers do not check the return value of pci_hp_add_bridge(). This may be problematic if the driver proceeds after pci_hp_add_bridge() fails. Link: https://lore.kernel.org/r/16a2442ea6ee896987a44df3ed509e4cfde44475.1714762038.git.namcao@linutronix.de Signed-off-by: Nam Cao <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]>
1 parent 4cece76 commit e6e9a9a

File tree

1 file changed

+6
-0
lines changed
  • drivers/pci/hotplug

1 file changed

+6
-0
lines changed

drivers/pci/hotplug/TODO

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ cpcihp:
66
->set_power callbacks in struct cpci_hp_controller_ops. Why were they
77
introduced? Can they be removed from the struct?
88

9+
* Returned code from pci_hp_add_bridge() is not checked.
10+
911
cpqphp:
1012

1113
* The driver spawns a kthread cpqhp_event_thread() which is woken by the
@@ -16,6 +18,8 @@ cpqphp:
1618
* A large portion of cpqphp_ctrl.c and cpqphp_pci.c concerns resource
1719
management. Doesn't this duplicate functionality in the core?
1820

21+
* Returned code from pci_hp_add_bridge() is not checked.
22+
1923
ibmphp:
2024

2125
* Implementations of hotplug_slot_ops callbacks such as get_adapter_present()
@@ -43,6 +47,8 @@ ibmphp:
4347
* A large portion of ibmphp_res.c and ibmphp_pci.c concerns resource
4448
management. Doesn't this duplicate functionality in the core?
4549

50+
* Returned code from pci_hp_add_bridge() is not checked.
51+
4652
sgi_hotplug:
4753

4854
* Several functions access the pci_slot member in struct hotplug_slot even

0 commit comments

Comments
 (0)