Skip to content

Commit e807fa3

Browse files
committed
Merge branch 's390-qeth-fixes'
Julian Wiedmann says: ==================== s390/qeth: fixes 2020-06-17 please apply the following patch series for qeth to netdev's net tree. The first patch fixes a regression in the error handling for a specific cmd type. I have some follow-ups queued up for net-next to clean this up properly... The second patch fine-tunes the HW offload restrictions that went in with this merge window. In some setups we don't need to apply them. ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents f3c7a6e + 8cebedb commit e807fa3

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

drivers/s390/net/qeth_core_main.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4544,9 +4544,6 @@ static int qeth_setadpparms_set_access_ctrl_cb(struct qeth_card *card,
45444544
int fallback = *(int *)reply->param;
45454545

45464546
QETH_CARD_TEXT(card, 4, "setaccb");
4547-
if (cmd->hdr.return_code)
4548-
return -EIO;
4549-
qeth_setadpparms_inspect_rc(cmd);
45504547

45514548
access_ctrl_req = &cmd->data.setadapterparms.data.set_access_ctrl;
45524549
QETH_CARD_TEXT_(card, 2, "rc=%d",
@@ -4556,7 +4553,7 @@ static int qeth_setadpparms_set_access_ctrl_cb(struct qeth_card *card,
45564553
QETH_DBF_MESSAGE(3, "ERR:SET_ACCESS_CTRL(%#x) on device %x: %#x\n",
45574554
access_ctrl_req->subcmd_code, CARD_DEVID(card),
45584555
cmd->data.setadapterparms.hdr.return_code);
4559-
switch (cmd->data.setadapterparms.hdr.return_code) {
4556+
switch (qeth_setadpparms_inspect_rc(cmd)) {
45604557
case SET_ACCESS_CTRL_RC_SUCCESS:
45614558
if (card->options.isolation == ISOLATION_MODE_NONE) {
45624559
dev_info(&card->gdev->dev,
@@ -6840,9 +6837,11 @@ netdev_features_t qeth_features_check(struct sk_buff *skb,
68406837
struct net_device *dev,
68416838
netdev_features_t features)
68426839
{
6840+
struct qeth_card *card = dev->ml_priv;
6841+
68436842
/* Traffic with local next-hop is not eligible for some offloads: */
6844-
if (skb->ip_summed == CHECKSUM_PARTIAL) {
6845-
struct qeth_card *card = dev->ml_priv;
6843+
if (skb->ip_summed == CHECKSUM_PARTIAL &&
6844+
card->options.isolation != ISOLATION_MODE_FWD) {
68466845
netdev_features_t restricted = 0;
68476846

68486847
if (skb_is_gso(skb) && !netif_needs_gso(skb, features))

0 commit comments

Comments
 (0)