Skip to content

Commit e8448a6

Browse files
EHfivelinusw
authored andcommitted
pinctrl: rockchip: fix pinmux bits for RK3328 GPIO2-B pins
The pinmux bits for GPIO2-B0 to GPIO2-B6 actually have 2 bits width, correct the bank flag for GPIO2-B. The pinmux bits for GPIO2-B7 is recalculated so it remain unchanged. The pinmux bits for those pins are not explicitly specified in RK3328 TRM, however we can get hint from pad name and its correspinding IOMUX setting for pins in interface descriptions. The correspinding IOMIX settings for GPIO2-B0 to GPIO2-B6 can be found in the same row next to occurrences of following pad names in RK3328 TRM. GPIO2-B0: IO_SPIclkm0_GPIO2B0vccio5 GPIO2-B1: IO_SPItxdm0_GPIO2B1vccio5 GPIO2-B2: IO_SPIrxdm0_GPIO2B2vccio5 GPIO2-B3: IO_SPIcsn0m0_GPIO2B3vccio5 GPIO2-B4: IO_SPIcsn1m0_FLASHvol_sel_GPIO2B4vccio5 GPIO2-B5: IO_ I2C2sda_TSADCshut_GPIO2B5vccio5 GPIO2-B6: IO_ I2C2scl_GPIO2B6vccio5 This fix has been tested on NanoPi R2S for fixing confliting pinmux bits between GPIO2-B7 with GPIO2-B5. Signed-off-by: Huang-Huang Bao <[email protected]> Reviewed-by: Heiko Stuebner <[email protected]> Fixes: 3818e4a ("pinctrl: rockchip: Add rk3328 pinctrl support") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent adec57f commit e8448a6

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

drivers/pinctrl/pinctrl-rockchip.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -634,12 +634,6 @@ static struct rockchip_mux_recalced_data rk3308_mux_recalced_data[] = {
634634

635635
static struct rockchip_mux_recalced_data rk3328_mux_recalced_data[] = {
636636
{
637-
.num = 2,
638-
.pin = 12,
639-
.reg = 0x24,
640-
.bit = 8,
641-
.mask = 0x3
642-
}, {
643637
.num = 2,
644638
.pin = 15,
645639
.reg = 0x28,
@@ -3763,7 +3757,7 @@ static struct rockchip_pin_bank rk3328_pin_banks[] = {
37633757
PIN_BANK_IOMUX_FLAGS(0, 32, "gpio0", 0, 0, 0, 0),
37643758
PIN_BANK_IOMUX_FLAGS(1, 32, "gpio1", 0, 0, 0, 0),
37653759
PIN_BANK_IOMUX_FLAGS(2, 32, "gpio2", 0,
3766-
IOMUX_WIDTH_3BIT,
3760+
0,
37673761
IOMUX_WIDTH_3BIT,
37683762
0),
37693763
PIN_BANK_IOMUX_FLAGS(3, 32, "gpio3",

0 commit comments

Comments
 (0)