Skip to content

Commit e86f2b0

Browse files
author
Mike Snitzer
committed
dm: simplify basic targets
Remove needless factoring and remap bi_sector regardless of bio_sectors() being non-zero. Signed-off-by: Mike Snitzer <[email protected]>
1 parent 442761f commit e86f2b0

File tree

3 files changed

+4
-14
lines changed

3 files changed

+4
-14
lines changed

drivers/md/dm-delay.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -296,8 +296,7 @@ static int delay_map(struct dm_target *ti, struct bio *bio)
296296
}
297297
delayed->class = c;
298298
bio_set_dev(bio, c->dev->bdev);
299-
if (bio_sectors(bio))
300-
bio->bi_iter.bi_sector = c->start + dm_target_offset(ti, bio->bi_iter.bi_sector);
299+
bio->bi_iter.bi_sector = c->start + dm_target_offset(ti, bio->bi_iter.bi_sector);
301300

302301
return delay_bio(dc, c, bio);
303302
}

drivers/md/dm-flakey.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -280,9 +280,7 @@ static void flakey_map_bio(struct dm_target *ti, struct bio *bio)
280280
struct flakey_c *fc = ti->private;
281281

282282
bio_set_dev(bio, fc->dev->bdev);
283-
if (bio_sectors(bio) || op_is_zone_mgmt(bio_op(bio)))
284-
bio->bi_iter.bi_sector =
285-
flakey_map_sector(ti, bio->bi_iter.bi_sector);
283+
bio->bi_iter.bi_sector = flakey_map_sector(ti, bio->bi_iter.bi_sector);
286284
}
287285

288286
static void corrupt_bio_data(struct bio *bio, struct flakey_c *fc)

drivers/md/dm-linear.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -84,19 +84,12 @@ static sector_t linear_map_sector(struct dm_target *ti, sector_t bi_sector)
8484
return lc->start + dm_target_offset(ti, bi_sector);
8585
}
8686

87-
static void linear_map_bio(struct dm_target *ti, struct bio *bio)
87+
static int linear_map(struct dm_target *ti, struct bio *bio)
8888
{
8989
struct linear_c *lc = ti->private;
9090

9191
bio_set_dev(bio, lc->dev->bdev);
92-
if (bio_sectors(bio) || op_is_zone_mgmt(bio_op(bio)))
93-
bio->bi_iter.bi_sector =
94-
linear_map_sector(ti, bio->bi_iter.bi_sector);
95-
}
96-
97-
static int linear_map(struct dm_target *ti, struct bio *bio)
98-
{
99-
linear_map_bio(ti, bio);
92+
bio->bi_iter.bi_sector = linear_map_sector(ti, bio->bi_iter.bi_sector);
10093

10194
return DM_MAPIO_REMAPPED;
10295
}

0 commit comments

Comments
 (0)