Skip to content

Commit e878476

Browse files
Xiu Jianfenghtejun
authored andcommitted
cgroup/cpuset: Avoid clearing CS_SCHED_LOAD_BALANCE twice
In cpuset_css_online(), CS_SCHED_LOAD_BALANCE will be cleared twice, the former one in the is_in_v2_mode() case could be removed because is_in_v2_mode() can be true for cgroup v1 if the "cpuset_v2_mode" mount option is specified, that balance flag change isn't appropriate for this particular case. Signed-off-by: Xiu Jianfeng <[email protected]> Signed-off-by: Tejun Heo <[email protected]>
1 parent 8996f93 commit e878476

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

kernel/cgroup/cpuset.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4052,11 +4052,6 @@ static int cpuset_css_online(struct cgroup_subsys_state *css)
40524052
cs->effective_mems = parent->effective_mems;
40534053
cs->use_parent_ecpus = true;
40544054
parent->child_ecpus_count++;
4055-
/*
4056-
* Clear CS_SCHED_LOAD_BALANCE if parent is isolated
4057-
*/
4058-
if (!is_sched_load_balance(parent))
4059-
clear_bit(CS_SCHED_LOAD_BALANCE, &cs->flags);
40604055
}
40614056

40624057
/*

0 commit comments

Comments
 (0)