ksmbd: Remove redundant 'flush_workqueue()' calls

tititiou36 · smfrench · commit e8d585b2f68c · 2021-11-06T23:52:06.000-05:00
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
- 	flush_workqueue(E);
	destroy_workqueue(E);

Acked-by: Namjae Jeon &lt;linkinjeon@kernel.org&gt;
Signed-off-by: Christophe JAILLET &lt;christophe.jaillet@wanadoo.fr&gt;
Signed-off-by: Steve French &lt;stfrench@microsoft.com&gt;
diff --git a/fs/ksmbd/ksmbd_work.c b/fs/ksmbd/ksmbd_work.c
@@ -69,7 +69,6 @@ int ksmbd_workqueue_init(void)
 
 void ksmbd_workqueue_destroy(void)
 {
-	flush_workqueue(ksmbd_wq);
 	destroy_workqueue(ksmbd_wq);
 	ksmbd_wq = NULL;
 }
diff --git a/fs/ksmbd/transport_rdma.c b/fs/ksmbd/transport_rdma.c
@@ -2043,7 +2043,6 @@ int ksmbd_rdma_destroy(void)
 	smb_direct_listener.cm_id = NULL;
 
 	if (smb_direct_wq) {
-		flush_workqueue(smb_direct_wq);
 		destroy_workqueue(smb_direct_wq);
 		smb_direct_wq = NULL;
 	}

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,6 @@ int ksmbd_workqueue_init(void)`
`69`	`69`
`70`	`70`	`void ksmbd_workqueue_destroy(void)`
`71`	`71`	`{`
`72`		`- flush_workqueue(ksmbd_wq);`
`73`	`72`	`destroy_workqueue(ksmbd_wq);`
`74`	`73`	`ksmbd_wq = NULL;`
`75`	`74`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2043,7 +2043,6 @@ int ksmbd_rdma_destroy(void)`
`2043`	`2043`	`smb_direct_listener.cm_id = NULL;`
`2044`	`2044`
`2045`	`2045`	`if (smb_direct_wq) {`
`2046`		`- flush_workqueue(smb_direct_wq);`
`2047`	`2046`	`destroy_workqueue(smb_direct_wq);`
`2048`	`2047`	`smb_direct_wq = NULL;`
`2049`	`2048`	`}`