Skip to content

Commit e9229d5

Browse files
Shang XiaoJingacmel
authored andcommitted
perf vendor events arm64: Fix incorrect Hisi hip08 L3 metrics
Commit 0cc177c ("perf vendor events arm64: Add Hisi hip08 L3 metrics") add L3 metrics of hip08, but some metrics (IF_BP_MISP_BR_RET, IF_BP_MISP_BR_RET, IF_BP_MISP_BR_BL) have incorrect event number due to the mistakes in document, which caused incorrect result. Fix the incorrect metrics. Before: 65,811,214,308 armv8_pmuv3_0/event=0x1014/ # 18.87 push_branch # -40.19 other_branch 3,564,316,780 BR_MIS_PRED # 0.51 indirect_branch # 21.81 pop_branch After: 6,537,146,245 BR_MIS_PRED # 0.48 indirect_branch # 0.47 pop_branch # 0.00 push_branch # 0.05 other_branch Fixes: 0cc177c ("perf vendor events arm64: Add Hisi hip08 L3 metrics") Reviewed-by: John Garry <[email protected]> Signed-off-by: Shang XiaoJing <[email protected]> Acked-by: James Clark <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: John Garry <[email protected]> Cc: Kajol Jain <[email protected]> Cc: Leo Yan <[email protected]> Cc: [email protected] Cc: Mark Rutland <[email protected]> Cc: Mike Leach <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Will Deacon <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent cba04f3 commit e9229d5

File tree

1 file changed

+3
-3
lines changed
  • tools/perf/pmu-events/arch/arm64/hisilicon/hip08

1 file changed

+3
-3
lines changed

tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,21 +112,21 @@
112112
"MetricName": "indirect_branch"
113113
},
114114
{
115-
"MetricExpr": "(armv8_pmuv3_0@event\\=0x1014@ + armv8_pmuv3_0@event\\=0x1018@) / BR_MIS_PRED",
115+
"MetricExpr": "(armv8_pmuv3_0@event\\=0x1013@ + armv8_pmuv3_0@event\\=0x1016@) / BR_MIS_PRED",
116116
"PublicDescription": "Push branch L3 topdown metric",
117117
"BriefDescription": "Push branch L3 topdown metric",
118118
"MetricGroup": "TopDownL3",
119119
"MetricName": "push_branch"
120120
},
121121
{
122-
"MetricExpr": "armv8_pmuv3_0@event\\=0x100c@ / BR_MIS_PRED",
122+
"MetricExpr": "armv8_pmuv3_0@event\\=0x100d@ / BR_MIS_PRED",
123123
"PublicDescription": "Pop branch L3 topdown metric",
124124
"BriefDescription": "Pop branch L3 topdown metric",
125125
"MetricGroup": "TopDownL3",
126126
"MetricName": "pop_branch"
127127
},
128128
{
129-
"MetricExpr": "(BR_MIS_PRED - armv8_pmuv3_0@event\\=0x1010@ - armv8_pmuv3_0@event\\=0x1014@ - armv8_pmuv3_0@event\\=0x1018@ - armv8_pmuv3_0@event\\=0x100c@) / BR_MIS_PRED",
129+
"MetricExpr": "(BR_MIS_PRED - armv8_pmuv3_0@event\\=0x1010@ - armv8_pmuv3_0@event\\=0x1013@ - armv8_pmuv3_0@event\\=0x1016@ - armv8_pmuv3_0@event\\=0x100d@) / BR_MIS_PRED",
130130
"PublicDescription": "Other branch L3 topdown metric",
131131
"BriefDescription": "Other branch L3 topdown metric",
132132
"MetricGroup": "TopDownL3",

0 commit comments

Comments
 (0)