Skip to content

Commit e9f5942

Browse files
boryaskdave
authored andcommitted
btrfs: set default discard iops_limit to 1000
Previously, the default was a relatively conservative 10. This results in a 100ms delay, so with ~300 discards in a commit, it takes the full 30s till the next commit to finish the discards. On a workstation, this results in the disk never going idle, wasting power/battery, etc. Set the default to 1000, which results in using the smallest possible delay, currently, which is 1ms. This has shown to not pathologically keep the disk busy by the original reporter. Link: https://lore.kernel.org/linux-btrfs/Y%2F+n1wS%2F4XAH7X1p@nz/ Link: https://bugzilla.redhat.com/show_bug.cgi?id=2182228 CC: [email protected] # 6.2+ Reviewed-by: Neal Gompa <[email protected] Signed-off-by: Boris Burkov <[email protected]> Reviewed-by: David Sterba <[email protected]> Signed-off-by: David Sterba <[email protected]>
1 parent 68d99ab commit e9f5942

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/btrfs/discard.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
#define BTRFS_DISCARD_TARGET_MSEC (6 * 60 * 60UL * MSEC_PER_SEC)
6161
#define BTRFS_DISCARD_MIN_DELAY_MSEC (1UL)
6262
#define BTRFS_DISCARD_MAX_DELAY_MSEC (1000UL)
63-
#define BTRFS_DISCARD_MAX_IOPS (10U)
63+
#define BTRFS_DISCARD_MAX_IOPS (1000U)
6464

6565
/* Monotonically decreasing minimum length filters after index 0 */
6666
static int discard_minlen[BTRFS_NR_DISCARD_LISTS] = {

0 commit comments

Comments
 (0)