Skip to content

Commit eab167f

Browse files
ffainellidavem330
authored andcommitted
net: dsa: b53: Fix valid setting for MDB entries
When support for the MDB entries was added, the valid bit was correctly changed to be assigned depending on the remaining port bitmask, that is, if there were no more ports added to the entry's port bitmask, the entry now becomes invalid. There was another assignment a few lines below that would override this which would invalidate entries even when there were still multiple ports left in the MDB entry. Fixes: 5d65b64 ("net: dsa: b53: Add support for MDB") Reviewed-by: Andrew Lunn <[email protected]> Signed-off-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 2e97b0c commit eab167f

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/net/dsa/b53/b53_common.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1561,7 +1561,6 @@ static int b53_arl_op(struct b53_device *dev, int op, int port,
15611561
ent.is_valid = !!(ent.port);
15621562
}
15631563

1564-
ent.is_valid = is_valid;
15651564
ent.vid = vid;
15661565
ent.is_static = true;
15671566
ent.is_age = false;

0 commit comments

Comments
 (0)