ALSA: ump: remove unnecessary check on blk

Luo Yifan · tiwai · commit eab936aa8500 · 2024-11-08T15:07:33.000+01:00
The unsigned expression 'blk' will never be negative, so remove the unnecessary check. Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com> Link: https://patch.msgid.link/20241108032702.217168-1-luoyifan@cmss.chinamobile.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/core/ump.c b/sound/core/ump.c
@@ -366,7 +366,7 @@ int snd_ump_block_new(struct snd_ump_endpoint *ump, unsigned int blk,
 {
 	struct snd_ump_block *fb, *p;
 
-	if (blk < 0 || blk >= SNDRV_UMP_MAX_BLOCKS)
+	if (blk >= SNDRV_UMP_MAX_BLOCKS)
 		return -EINVAL;
 
 	if (snd_ump_get_block(ump, blk))

Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,7 @@ int snd_ump_block_new(struct snd_ump_endpoint *ump, unsigned int blk,`
`366`	`366`	`{`
`367`	`367`	`struct snd_ump_block fb, p;`
`368`	`368`
`369`		`- if (blk < 0 \|\| blk >= SNDRV_UMP_MAX_BLOCKS)`
	`369`	`+ if (blk >= SNDRV_UMP_MAX_BLOCKS)`
`370`	`370`	`return -EINVAL;`
`371`	`371`
`372`	`372`	`if (snd_ump_get_block(ump, blk))`