Skip to content

Commit eaec2b0

Browse files
ZhiqiangLiu26Christian Brauner
authored andcommitted
signal: check sig before setting info in kill_pid_usb_asyncio
In kill_pid_usb_asyncio, if signal is not valid, we do not need to set info struct. Signed-off-by: Zhiqiang Liu <[email protected]> Acked-by: Christian Brauner <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Christian Brauner <[email protected]>
1 parent 8f3d9f3 commit eaec2b0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

kernel/signal.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1510,15 +1510,15 @@ int kill_pid_usb_asyncio(int sig, int errno, sigval_t addr,
15101510
unsigned long flags;
15111511
int ret = -EINVAL;
15121512

1513+
if (!valid_signal(sig))
1514+
return ret;
1515+
15131516
clear_siginfo(&info);
15141517
info.si_signo = sig;
15151518
info.si_errno = errno;
15161519
info.si_code = SI_ASYNCIO;
15171520
*((sigval_t *)&info.si_pid) = addr;
15181521

1519-
if (!valid_signal(sig))
1520-
return ret;
1521-
15221522
rcu_read_lock();
15231523
p = pid_task(pid, PIDTYPE_PID);
15241524
if (!p) {

0 commit comments

Comments
 (0)