Skip to content

Commit eb1d392

Browse files
committed
ACPI: PCI: Fix device reference counting in acpi_get_pci_dev()
Commit 63f534b ("ACPI: PCI: Rework acpi_get_pci_dev()") failed to reference count the device returned by acpi_get_pci_dev() as expected by its callers which in some cases may cause device objects to be dropped prematurely. Add the missing get_device() to acpi_get_pci_dev(). Fixes: 63f534b ("ACPI: PCI: Rework acpi_get_pci_dev()") Reported-by: Ville Syrjälä <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 9abf231 commit eb1d392

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/acpi/pci_root.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,7 @@ struct pci_dev *acpi_get_pci_dev(acpi_handle handle)
323323

324324
list_for_each_entry(pn, &adev->physical_node_list, node) {
325325
if (dev_is_pci(pn->dev)) {
326+
get_device(pn->dev);
326327
pci_dev = to_pci_dev(pn->dev);
327328
break;
328329
}

0 commit comments

Comments
 (0)