Skip to content

Commit eb2ee0e

Browse files
committed
drm/vblank: Use spin_(un)lock_irq() in drm_legacy_vblank_post_modeset()
This function is only ever called from ioctl context, so we're guaranteed to have interrupts enabled. Stop using the irqsave/irqrestore variants of spin_(un)lock_irq() to make this more obvious. Signed-off-by: Lyude Paul <[email protected]> Cc: Daniel Vetter <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: Daniel Vetter <[email protected]>
1 parent 92cc68e commit eb2ee0e

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/gpu/drm/drm_vblank.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1551,7 +1551,6 @@ static void drm_legacy_vblank_post_modeset(struct drm_device *dev,
15511551
unsigned int pipe)
15521552
{
15531553
struct drm_vblank_crtc *vblank = &dev->vblank[pipe];
1554-
unsigned long irqflags;
15551554

15561555
/* vblank is not initialized (IRQ not installed ?), or has been freed */
15571556
if (!drm_dev_has_vblank(dev))
@@ -1561,9 +1560,9 @@ static void drm_legacy_vblank_post_modeset(struct drm_device *dev,
15611560
return;
15621561

15631562
if (vblank->inmodeset) {
1564-
spin_lock_irqsave(&dev->vbl_lock, irqflags);
1563+
spin_lock_irq(&dev->vbl_lock);
15651564
drm_reset_vblank_timestamp(dev, pipe);
1566-
spin_unlock_irqrestore(&dev->vbl_lock, irqflags);
1565+
spin_unlock_irq(&dev->vbl_lock);
15671566

15681567
if (vblank->inmodeset & 0x2)
15691568
drm_vblank_put(dev, pipe);

0 commit comments

Comments
 (0)