Skip to content

Commit eb66553

Browse files
committed
drm/i915/bios: set default backlight controller index
With backlight controller set to -1 in intel_panel_init_alloc() to distinguish uninitialized values, and controller later being set only if it's present in VBT, we can end up with -1 for the controller: [drm:intel_bios_init_panel [i915]] VBT backlight PWM modulation frequency 200 Hz, active high, min brightness 0, level 255, controller 4294967295 There's no harm if it happens on platforms that ignore controller due to only one backlight controller being present, like on VLV above, but play it safe. Fixes: bf38bba ("drm/i915: Try to use the correct power sequencer intiially on bxt/glk") Cc: Ville Syrjälä <[email protected]> Signed-off-by: Jani Nikula <[email protected]> Reviewed-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit a0dcb06) Signed-off-by: Jani Nikula <[email protected]>
1 parent c90b155 commit eb66553

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/gpu/drm/i915/display/intel_bios.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1033,6 +1033,7 @@ parse_lfp_backlight(struct drm_i915_private *i915,
10331033
}
10341034

10351035
panel->vbt.backlight.type = INTEL_BACKLIGHT_DISPLAY_DDI;
1036+
panel->vbt.backlight.controller = 0;
10361037
if (i915->display.vbt.version >= 191) {
10371038
size_t exp_size;
10381039

0 commit comments

Comments
 (0)