Skip to content

Commit eb780dc

Browse files
Peter Zijlstrahansendc
authored andcommitted
mm: Remove pointless barrier() after pmdp_get_lockless()
pmdp_get_lockless() should itself imply any ordering required. Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Link: https://lkml.kernel.org/r/20221022114425.298833095%40infradead.org
1 parent d4a72e7 commit eb780dc

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

mm/hmm.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,6 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp,
362362
* values.
363363
*/
364364
pmd = pmdp_get_lockless(pmdp);
365-
barrier();
366365
if (!pmd_devmap(pmd) && !pmd_trans_huge(pmd))
367366
goto again;
368367

mm/vmscan.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4041,9 +4041,6 @@ static void walk_pmd_range(pud_t *pud, unsigned long start, unsigned long end,
40414041
for (i = pmd_index(start), addr = start; addr != end; i++, addr = next) {
40424042
pmd_t val = pmdp_get_lockless(pmd + i);
40434043

4044-
/* for pmdp_get_lockless() */
4045-
barrier();
4046-
40474044
next = pmd_addr_end(addr, end);
40484045

40494046
if (!pmd_present(val) || is_huge_zero_pmd(val)) {

0 commit comments

Comments
 (0)