mlxsw: core_thermal: Remove unnecessary assignments

idosch · kuba-moo · commit ec672931d150 · 2024-07-31T18:38:29.000-07:00
Setting both pointers to NULL is unnecessary since the code never checks whether these pointers are NULL or not. Remove the assignments. Signed-off-by: Ido Schimmel <idosch@nvidia.com> Reviewed-by: Vadim Pasternak <vadimp@nvidia.com> Signed-off-by: Petr Machata <petrm@nvidia.com> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com> Link: https://patch.msgid.link/ea646f5d7642fffd5393fa23650660ab8f77a511.1722345311.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c b/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c
@@ -468,8 +468,6 @@ mlxsw_thermal_module_init(struct mlxsw_thermal *thermal,
 static void mlxsw_thermal_module_fini(struct mlxsw_thermal_module *module_tz)
 {
 	mlxsw_thermal_module_tz_fini(module_tz->tzdev);
-	module_tz->tzdev = NULL;
-	module_tz->parent = NULL;
 }
 
 static int

Original file line number	Diff line number	Diff line change
`@@ -468,8 +468,6 @@ mlxsw_thermal_module_init(struct mlxsw_thermal *thermal,`
`468`	`468`	`static void mlxsw_thermal_module_fini(struct mlxsw_thermal_module *module_tz)`
`469`	`469`	`{`
`470`	`470`	`mlxsw_thermal_module_tz_fini(module_tz->tzdev);`
`471`		`- module_tz->tzdev = NULL;`
`472`		`- module_tz->parent = NULL;`
`473`	`471`	`}`
`474`	`472`
`475`	`473`	`static int`