Skip to content

Commit ec85147

Browse files
committed
drm/panel: sharp-lq101r1sx01: Fixed reversed "if" in remove
Commit d7d473d ("drm/panel: sharp-lq101r1sx01: Don't call disable at shutdown/remove") had a subtle bug. We should be calling sharp_panel_del() when the "sharp" variable is non-NULL, not when it's NULL. Fix. Fixes: d7d473d ("drm/panel: sharp-lq101r1sx01: Don't call disable at shutdown/remove") Cc: Thierry Reding <[email protected]> Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> Closes: https://lore.kernel.org/r/[email protected]/ Reviewed-by: Neil Armstrong <[email protected]> Signed-off-by: Douglas Anderson <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/20240708105221.1.I576751c661c7edb6b804dda405d10e2e71153e32@changeid
1 parent cb31c58 commit ec85147

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ static void sharp_panel_remove(struct mipi_dsi_device *dsi)
362362
dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err);
363363

364364
/* only detach from host for the DSI-LINK2 interface */
365-
if (!sharp)
365+
if (sharp)
366366
sharp_panel_del(sharp);
367367
}
368368

0 commit comments

Comments
 (0)