Skip to content

Commit eca4c0e

Browse files
Qi Zhengvireshk
authored andcommitted
OPP: fix error checking in opp_migrate_dentry()
Since commit ff9fb72 ("debugfs: return error values, not NULL") changed return value of debugfs_rename() in error cases from %NULL to %ERR_PTR(-ERROR), we should also check error values instead of NULL. Fixes: ff9fb72 ("debugfs: return error values, not NULL") Signed-off-by: Qi Zheng <[email protected]> Signed-off-by: Viresh Kumar <[email protected]>
1 parent 68d8ad3 commit eca4c0e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/opp/debugfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ static void opp_migrate_dentry(struct opp_device *opp_dev,
235235

236236
dentry = debugfs_rename(rootdir, opp_dev->dentry, rootdir,
237237
opp_table->dentry_name);
238-
if (!dentry) {
238+
if (IS_ERR(dentry)) {
239239
dev_err(dev, "%s: Failed to rename link from: %s to %s\n",
240240
__func__, dev_name(opp_dev->dev), dev_name(dev));
241241
return;

0 commit comments

Comments
 (0)