Skip to content

Commit ecc1ca9

Browse files
stuyod01jarkkojs
authored andcommitted
tpm_crb: ffa_tpm: fix/update comments describing the CRB over FFA ABI
-Fix the comment describing the 'start' function, which was a cut/paste mistake for a different function. -The comment for DIRECT_REQ and DIRECT_RESP only mentioned AArch32 and listed 32-bit function IDs. Update to include 64-bit. Signed-off-by: Stuart Yoder <[email protected]> Reviewed-by: Jarkko Sakkinen <[email protected]> Signed-off-by: Jarkko Sakkinen <[email protected]>
1 parent 8d67b79 commit ecc1ca9

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

drivers/char/tpm/tpm_crb_ffa.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,11 @@
3838
* messages.
3939
*
4040
* All requests with FFA_MSG_SEND_DIRECT_REQ and FFA_MSG_SEND_DIRECT_RESP
41-
* are using the AArch32 SMC calling convention with register usage as
42-
* defined in FF-A specification:
43-
* w0: Function ID (0x8400006F or 0x84000070)
41+
* are using the AArch32 or AArch64 SMC calling convention with register usage
42+
* as defined in FF-A specification:
43+
* w0: Function ID
44+
* -for 32-bit: 0x8400006F or 0x84000070
45+
* -for 64-bit: 0xC400006F or 0xC4000070
4446
* w1: Source/Destination IDs
4547
* w2: Reserved (MBZ)
4648
* w3-w7: Implementation defined, free to be used below
@@ -68,7 +70,8 @@
6870
#define CRB_FFA_GET_INTERFACE_VERSION 0x0f000001
6971

7072
/*
71-
* Return information on a given feature of the TPM service
73+
* Notifies the TPM service that a TPM command or TPM locality request is
74+
* ready to be processed, and allows the TPM service to process it.
7275
* Call register usage:
7376
* w3: Not used (MBZ)
7477
* w4: TPM service function ID, CRB_FFA_START

0 commit comments

Comments
 (0)