Skip to content

Commit ecc3ac2

Browse files
Mani-Sadhasivamandersson
authored andcommitted
arm64: dts: qcom: sm8450: Fix the msi-map entries
While adding the GIC ITS MSI support, it was found that the msi-map entries needed to be swapped to receive MSIs from the endpoint. But later it was identified that the swapping was needed due to a bug in the Qualcomm PCIe controller driver. And since the bug is now fixed with commit bf79e33 ("PCI: qcom: Enable BDF to SID translation properly"), let's fix the msi-map entries also to reflect the actual mapping in the hardware. Cc: [email protected] # 6.3: bf79e33 ("PCI: qcom: Enable BDF to SID translation properly") Fixes: ff384ab ("arm64: dts: qcom: sm8450: Use GIC-ITS for PCIe0 and PCIe1") Signed-off-by: Manivannan Sadhasivam <[email protected]> Reviewed-by: Neil Armstrong <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 8b8ec83 commit ecc3ac2

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

arch/arm64/boot/dts/qcom/sm8450.dtsi

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1777,12 +1777,8 @@
17771777
ranges = <0x01000000 0x0 0x00000000 0x0 0x60200000 0x0 0x100000>,
17781778
<0x02000000 0x0 0x60300000 0x0 0x60300000 0x0 0x3d00000>;
17791779

1780-
/*
1781-
* MSIs for BDF (1:0.0) only works with Device ID 0x5980.
1782-
* Hence, the IDs are swapped.
1783-
*/
1784-
msi-map = <0x0 &gic_its 0x5981 0x1>,
1785-
<0x100 &gic_its 0x5980 0x1>;
1780+
msi-map = <0x0 &gic_its 0x5980 0x1>,
1781+
<0x100 &gic_its 0x5981 0x1>;
17861782
msi-map-mask = <0xff00>;
17871783
interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>,
17881784
<GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>,
@@ -1900,12 +1896,8 @@
19001896
ranges = <0x01000000 0x0 0x00000000 0x0 0x40200000 0x0 0x100000>,
19011897
<0x02000000 0x0 0x40300000 0x0 0x40300000 0x0 0x1fd00000>;
19021898

1903-
/*
1904-
* MSIs for BDF (1:0.0) only works with Device ID 0x5a00.
1905-
* Hence, the IDs are swapped.
1906-
*/
1907-
msi-map = <0x0 &gic_its 0x5a01 0x1>,
1908-
<0x100 &gic_its 0x5a00 0x1>;
1899+
msi-map = <0x0 &gic_its 0x5a00 0x1>,
1900+
<0x100 &gic_its 0x5a01 0x1>;
19091901
msi-map-mask = <0xff00>;
19101902
interrupts = <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
19111903
<GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>,

0 commit comments

Comments
 (0)