Skip to content

Commit eccdb0f

Browse files
Leo-PLgregkh
authored andcommitted
serial: sc16is7xx: fix copy-paste errors in EFR_SWFLOWx_BIT constants
Comments attached to bits 0 and 1 incorrectly referenced bits 2 and 3, which don't match the datasheet - fix them. At the same time remove comments for individual constants, as they add nothing to the definitions themselves. Signed-off-by: Lech Perczak <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 0f5e389 commit eccdb0f

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/tty/serial/sc16is7xx.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -267,9 +267,9 @@
267267
* and writing to IER[7:4],
268268
* FCR[5:4], MCR[7:5]
269269
*/
270-
#define SC16IS7XX_EFR_SWFLOW3_BIT (1 << 3) /* SWFLOW bit 3 */
271-
#define SC16IS7XX_EFR_SWFLOW2_BIT (1 << 2) /* SWFLOW bit 2
272-
*
270+
#define SC16IS7XX_EFR_SWFLOW3_BIT (1 << 3)
271+
#define SC16IS7XX_EFR_SWFLOW2_BIT (1 << 2)
272+
/*
273273
* SWFLOW bits 3 & 2 table:
274274
* 00 -> no transmitter flow
275275
* control
@@ -281,10 +281,10 @@
281281
* XON1, XON2, XOFF1 and
282282
* XOFF2
283283
*/
284-
#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) /* SWFLOW bit 2 */
285-
#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) /* SWFLOW bit 3
286-
*
287-
* SWFLOW bits 3 & 2 table:
284+
#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1)
285+
#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0)
286+
/*
287+
* SWFLOW bits 1 & 0 table:
288288
* 00 -> no received flow
289289
* control
290290
* 01 -> receiver compares

0 commit comments

Comments
 (0)