Skip to content

Commit ed42c38

Browse files
Neeraj Upadhyaypaulmckrcu
authored andcommitted
rcu-tasks: Fix read-side primitives comment for call_rcu_tasks_trace
call_rcu_tasks_trace() does have read-side primitives - rcu_read_lock_trace() and rcu_read_unlock_trace(). Fix this information in the comments. Signed-off-by: Neeraj Upadhyay <[email protected]> Signed-off-by: Paul E. McKenney <[email protected]>
1 parent a6517e9 commit ed42c38

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

kernel/rcu/tasks.h

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1207,15 +1207,11 @@ static void exit_tasks_rcu_finish_trace(struct task_struct *t)
12071207
* @rhp: structure to be used for queueing the RCU updates.
12081208
* @func: actual callback function to be invoked after the grace period
12091209
*
1210-
* The callback function will be invoked some time after a full grace
1211-
* period elapses, in other words after all currently executing RCU
1212-
* read-side critical sections have completed. call_rcu_tasks_trace()
1213-
* assumes that the read-side critical sections end at context switch,
1214-
* cond_resched_rcu_qs(), or transition to usermode execution. As such,
1215-
* there are no read-side primitives analogous to rcu_read_lock() and
1216-
* rcu_read_unlock() because this primitive is intended to determine
1217-
* that all tasks have passed through a safe state, not so much for
1218-
* data-structure synchronization.
1210+
* The callback function will be invoked some time after a trace rcu-tasks
1211+
* grace period elapses, in other words after all currently executing
1212+
* trace rcu-tasks read-side critical sections have completed. These
1213+
* read-side critical sections are delimited by calls to rcu_read_lock_trace()
1214+
* and rcu_read_unlock_trace().
12191215
*
12201216
* See the description of call_rcu() for more detailed information on
12211217
* memory ordering guarantees.
@@ -1231,7 +1227,7 @@ EXPORT_SYMBOL_GPL(call_rcu_tasks_trace);
12311227
*
12321228
* Control will return to the caller some time after a trace rcu-tasks
12331229
* grace period has elapsed, in other words after all currently executing
1234-
* rcu-tasks read-side critical sections have elapsed. These read-side
1230+
* trace rcu-tasks read-side critical sections have elapsed. These read-side
12351231
* critical sections are delimited by calls to rcu_read_lock_trace()
12361232
* and rcu_read_unlock_trace().
12371233
*

0 commit comments

Comments
 (0)